Skip to content

Rejecting 'null' and 'undefined' as arguments for CollectionReference.doc() #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 6, 2017
Merged

Rejecting 'null' and 'undefined' as arguments for CollectionReference.doc() #188

merged 1 commit into from
Oct 6, 2017

Conversation

schmidt-sebastian
Copy link
Contributor

This is for Google-internal bug b/67419579

mikelehen
mikelehen approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@schmidt-sebastian schmidt-sebastian merged commit 8bbbece into master Oct 6, 2017
@jshcrowthe jshcrowthe deleted the mrschmidt-undefinedornull branch October 6, 2017 21:32
@firebase firebase locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mikelehen mikelehen mikelehen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mikelehen mikelehen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schmidt-sebastian @mikelehen